[ 
https://issues.apache.org/jira/browse/IGNITE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603538#comment-16603538
 ] 

Nikolay Izhikov commented on IGNITE-8485:
-----------------------------------------

[~vozerov]

I've fixed all comments from your first code review:

1. {{encrypted}} renamed to {{isEncryptionEnabled}}

2. Ticket to add {{isEncryptionEnabled}} created. 

3. .Net SPI implementation created.

4. CRC of encrypted page calculated and stored in the persistent store. We can 
check persisted data integrity on reading from a file.

5. {{EncryptionKey}} removed. {{Serializable}} used instead.

6. I've keep {{NoonEncryptionSpi}} - it required in for a internal logic.

7. {{keySize}} and {{masterKeName}} are now can be setted by user.

8. MVCC PageIO checked.

9. {{GenerateEncryptionKeyRequst}} now send via communication SPI.

10. SPI implementation renamed to AESEncryptionSpi and moved to the 
corresponding package.

11. Some tests added.

PDS tests group are executed with encryption mode forced for all caches.

PR - https://github.com/apache/ignite/pull/4634
Tests - https://ci.ignite.apache.org/viewLog.html?buildId=1794649

Please, take a look on main PR one more time - 
https://github.com/apache/ignite/pull/4167

> TDE - Phase-1
> -------------
>
>                 Key: IGNITE-8485
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8485
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Nikolay Izhikov
>            Assignee: Nikolay Izhikov
>            Priority: Critical
>             Fix For: 2.7
>
>
> Basic support for a Transparent Data Encryption should be implemented:
> 1. Usage of standard JKS, Java Security.
> 2. Persistent Data Encryption/Decryption.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to