[
https://issues.apache.org/jira/browse/IGNITE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709996#comment-16709996
]
Pavel Kovalenko commented on IGNITE-10003:
------------------------------------------
[~andrey-kuznetsov] Thank you for contribution.
I have a question regarding this change. Do we have any tests checking that
critical failure is raised when checkpointReadLock is timed out? If yes, please
add a check that critical failure type SYSTEM_WORKER_BLOCKED is used in that
case. If no, please add such test.
Also, your branch is a little bit outdated comparing to master and it's hard to
analyze which tests didn't pass expectedly. Could you please merge the latest
master, re-run tests and get the green visa from
[MTCGA|https://mtcga.gridgain.com/]?
> Raise SYSTEM_WORKER_BLOCKED instead of CRITICAL_ERROR when checkpoint read
> lock timeout detected
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-10003
> URL: https://issues.apache.org/jira/browse/IGNITE-10003
> Project: Ignite
> Issue Type: Task
> Affects Versions: 2.7
> Reporter: Andrey Kuznetsov
> Assignee: Andrey Kuznetsov
> Priority: Trivial
> Fix For: 2.8
>
>
> {{GridCacheDatabaseSharedManager#failCheckpointReadLock}} should report
> {{SYSTEM_WORKER_BLOCKED}} to failure handler: it is closer to the truth and
> default consequenses are not so severe as opposed to {{CRITICAL_ERROR}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
