[
https://issues.apache.org/jira/browse/IGNITE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725865#comment-16725865
]
Pavel Kovalenko commented on IGNITE-10003:
------------------------------------------
[~andrey-kuznetsov] Overall looks good. But for me, the test can be written in
a much easier approach.
1) Disable automatic checkpoints by timeout.
2) You can introduce checkpointWriteLock/Unlock methods in
GridCacheDatabaseSharedManager and explicitly acquire write lock in test code.
3) Then try to acquire cp readLock and wait till it will be failed with a
timeout exception.
4) Check that the failure handler was called and failure type was as expected.
In this approach, there will be no needs to "cross fingers" :)
> Raise SYSTEM_WORKER_BLOCKED instead of CRITICAL_ERROR when checkpoint read
> lock timeout detected
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-10003
> URL: https://issues.apache.org/jira/browse/IGNITE-10003
> Project: Ignite
> Issue Type: Task
> Affects Versions: 2.7
> Reporter: Andrey Kuznetsov
> Assignee: Andrey Kuznetsov
> Priority: Trivial
> Fix For: 2.8
>
>
> {{GridCacheDatabaseSharedManager#failCheckpointReadLock}} should report
> {{SYSTEM_WORKER_BLOCKED}} to failure handler: it is closer to the truth and
> default consequenses are not so severe as opposed to {{CRITICAL_ERROR}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
