[
https://issues.apache.org/jira/browse/IGNITE-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765866#comment-16765866
]
Rodion commented on IGNITE-8558:
--------------------------------
[~oignatenko],Hi Oleg! I saw that you have some commits in
GridAbstractTest.java!
Could you review my ticket? Maxim hasn't enough time now.
I change flag in method stopAllGrids(), in method afterLastTest() because all
assertions checks before it calls. And processes interruption has not fluent on
test, but can lead to the time economy. Also I deleted some bolerplates where
code duplicates
> Provide an opportunity to stop grids and cancel tasks after execution all
> tests
> -------------------------------------------------------------------------------
>
> Key: IGNITE-8558
> URL: https://issues.apache.org/jira/browse/IGNITE-8558
> Project: Ignite
> Issue Type: Sub-task
> Affects Versions: 2.6
> Reporter: Maxim Muzafarov
> Assignee: Rodion
> Priority: Minor
> Fix For: 2.8
>
>
> The -IGNITE-6842- issue provides an ability gracefully shutdown all ignite
> instances by default after execution of tests. Ignite instances are stopped
> by calling the method - {{stopAllGrids}} ({{cancel = false}} is used). You
> can refer to these lines of code for the details of how the node stopped:
> {code:java|title=GridAbstractTest.java:1789}
> if (isSafeTopology()) {
> stopAllGrids(false);
> if (stopGridErr) {
> err = new RuntimeException("Not all Ignite instances has been
> stopped. " +
> "Please, see log for details.", err);
> }
> }
> {code}
> As part of IGNITE-8266 a lot of boilerplate code have been successfully
> removed. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
> super.afterTestsStopped();
> stopAllGrids();
> }
> {code}
> We need to,
> * Provide the ability to override the behaviour of gracefully instance
> shutdown and use {{stopAllGirds(true)}} after all tests execution. Assume a
> new method would be introduced like {{GridAbstractTest#isSafeTopology}}, so
> the behaviour can be overridden in subclasses.
> * Remove the other boilerplate parts of the code. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
> stopAllGrids(true);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
