[
https://issues.apache.org/jira/browse/IGNITE-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765912#comment-16765912
]
Oleg Ignatenko commented on IGNITE-8558:
----------------------------------------
[~RodionVl] please find review notes below.
* I noticed that TC bot visa is obtained for RunAll - suggest to obtain it for
"RunAll (Nightly)" instead (in TC bot dropdown it is denoted as
"IgniteTests24Java8_RunAllNightly"). Normally I would say plain RunAll is
sufficient, but since your changes involve GridAbstractTest it is better to
exercise some extra care in verifying these by extended testing performed by
nightly run.
* ExplainSelfTest code in method afterTestsStopped doesn't invoke code from
superclass ({{super.afterTestsStopped()}}) - is that intentional? If not then
please recover that.
* I noticed a couple extra empty lines left after removing some methods. These
lines would better be deleted to keep uniform formatting of source code:
line #150 in JdbcThinMetadataPrimaryKeysSelfTest
line #191 in JdbcThinTransactionsAbstractComplexSelfTest
line #42 in IgniteDistributedModelBuilderTest
line #56 in MLPTrainerMnistIntegrationTest
line #44 in CacheBasedLabelPairCursorTest
Other than above, all the changes I checked make very good sense and after
addressing points listed above I would _strongly_ recommend merging this PR.
> Provide an opportunity to stop grids and cancel tasks after execution all
> tests
> -------------------------------------------------------------------------------
>
> Key: IGNITE-8558
> URL: https://issues.apache.org/jira/browse/IGNITE-8558
> Project: Ignite
> Issue Type: Sub-task
> Affects Versions: 2.6
> Reporter: Maxim Muzafarov
> Assignee: Rodion
> Priority: Minor
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.8
>
>
> The -IGNITE-6842- issue provides an ability gracefully shutdown all ignite
> instances by default after execution of tests. Ignite instances are stopped
> by calling the method - {{stopAllGrids}} ({{cancel = false}} is used). You
> can refer to these lines of code for the details of how the node stopped:
> {code:java|title=GridAbstractTest.java:1789}
> if (isSafeTopology()) {
> stopAllGrids(false);
> if (stopGridErr) {
> err = new RuntimeException("Not all Ignite instances has been
> stopped. " +
> "Please, see log for details.", err);
> }
> }
> {code}
> As part of IGNITE-8266 a lot of boilerplate code have been successfully
> removed. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
> super.afterTestsStopped();
> stopAllGrids();
> }
> {code}
> We need to,
> * Provide the ability to override the behaviour of gracefully instance
> shutdown and use {{stopAllGirds(true)}} after all tests execution. Assume a
> new method would be introduced like {{GridAbstractTest#isSafeTopology}}, so
> the behaviour can be overridden in subclasses.
> * Remove the other boilerplate parts of the code. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
> stopAllGrids(true);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
