[
https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822749#comment-16822749
]
Vyacheslav Daradur commented on IGNITE-11277:
---------------------------------------------
[~Mmuzaf], I looked through the PR and have some question:
1. Do we really need a new dependency {{com.puppycrawl.tools}}? Looks like
{{maven-checkstyle-plugin}} [already
have|https://github.com/apache/maven-checkstyle-plugin/blob/master/pom.xml#L208]
this in dependencies.
2. Do we really need a new profile for checking? Can't we just use {{mvn
validate}} or {{mvn checkstyle:check}}?
> Use maven plugin as default code style checker for project
> ----------------------------------------------------------
>
> Key: IGNITE-11277
> URL: https://issues.apache.org/jira/browse/IGNITE-11277
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: inspections
> Fix For: 2.8
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough.
> The suite has a {{FAILED}} status for more than 2 months due to some issues
> on TeamCity application [2]. It confuses most of the members of the Apache
> Ignite community.
> Moreover, this suite is no longer checks configured rules. For instance, in
> the master branch, 11 {{Unused imports}} can be found (e.g. for
> {{IgniteCachePutAllRestartTest}
> [3]).
> I think the maven-checkstyle-plugin should be used as the default code style
> checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
