[
https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823305#comment-16823305
]
Maxim Muzafarov commented on IGNITE-11277:
------------------------------------------
[~daradurvs]
1. The {{maven-checkstyle-plugin}} has {{6.18}} by default and for some of the
configured rules, it is work now exactly right as it expects. For instance,
this import of EventListener is used only in Javadoc description
[ContinuousQuery.java#L26|https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/cache/query/ContinuousQuery.java#L26]
and is marked by this version of the plugin as {{unused}} what is not right.
The current behaviour has been fixed
https://github.com/checkstyle/checkstyle/issues/4606 since 8.1 version, so for
the dependency {{com.puppycrawl.tools}} you mentioned before I've set (the
{{latest}}) 8.19 version.
2. The plugin configuration is used in the separate profile for two common
reasons: to speed up the local build for developers (rules checking is time
consuming operation) and not to add an unswitchable features to the Ignites
project code.
> Use maven plugin as default code style checker for project
> ----------------------------------------------------------
>
> Key: IGNITE-11277
> URL: https://issues.apache.org/jira/browse/IGNITE-11277
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: inspections
> Fix For: 2.8
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough.
> The suite has a {{FAILED}} status for more than 2 months due to some issues
> on TeamCity application [2]. It confuses most of the members of the Apache
> Ignite community.
> Moreover, this suite is no longer checks configured rules. For instance, in
> the master branch, 11 {{Unused imports}} can be found (e.g. for
> {{IgniteCachePutAllRestartTest}
> [3]).
> I think the maven-checkstyle-plugin should be used as the default code style
> checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
