[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915082#comment-16915082
]
Saikat Maitra commented on IGNITE-7285:
---------------------------------------
Hi [~Pavlukhin]
Thank you for your feedback. I have following clarification and questions
related to the changes you have asked.
# I ran tests for Distributed Query and local query like
IgniteCacheReplicatedQuerySelfTest,
IgniteCacheLocalQueryCancelOrTimeoutSelfTest and I see that timeout value is
passed. Can you share an example in which Query or execution mode you can see
that timeout is not passed?
# I observed that QueryParameters initialization is occurring in
QueryParameters.fromQuery(SqlFieldsQuery qry) method and QueryParameters does
not have GridKernalContext reference so it will not be feasible to access the
ctx.config().getDefaultQueryTimeout() upon {{QueryParameters}} initialization.
# If you observe timeout in SqlFieldsQuery get validated in
QueryUtils.validateTimeout(timeout, timeUnit) and it asserts that timeout value
of SqlFieldsQuery is more than equal 0. Now if we allow feature to disable
timeout of particular query using ({{SqlFieldsQuery.setTimeout(0)}}) then
ctx.config().getDefaultQueryTimeout() will never get used.
Regards,
Saikat
> Add default query timeout
> -------------------------
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
> Affects Versions: 2.3
> Reporter: Valentin Kulichenko
> Assignee: Saikat Maitra
> Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
