[ 
https://issues.apache.org/jira/browse/JCLOUDS-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802348#comment-13802348
 ] 

Ignasi Barrera commented on JCLOUDS-275:
----------------------------------------

This is something that will be fixed in the Abiquo API, but in the meanwhile, I 
think it would be better to rename the methods.
If we silently change the getter/setter implementation to perform the 
conversion, we might break existing integrations. Renaming the methods will 
properly reflect the real units being used and anyone calling those methods 
would notice as the call will have to be changed.

This should be a pretty straightforward fix. Do you want to help and send a 
pull request with the fix? :)

> Abiquo Hard Drive Size limits are in bytes, instead of Mb
> ---------------------------------------------------------
>
>                 Key: JCLOUDS-275
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-275
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-labs
>    Affects Versions: 1.7.0
>            Reporter: Carlos García Ibáñez
>              Labels: abiquo
>         Attachments: attach_volume.txt
>
>
> When setting the hard drive limits for an Enterprise or a Virtual Datacenter 
> we use the setLimitsInMb() method in the class DomainWithLimitsWrapper. The 
> values passed are then supposed to be in Mb, but we have noticed that the 
> Abiquo platform is interpreting them as bytes. The same applies to the 
> corresponding getters for the soft and hard limits.A conversion should be 
> made before sending the values to Abiquo (for the setters) or after 
> retrieving them (in the getters). Or maybe the methods should be renamed to 
> remove the reference to the units (Mb).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to