[ 
https://issues.apache.org/jira/browse/JCLOUDS-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802717#comment-13802717
 ] 

Carlos García Ibáñez commented on JCLOUDS-275:
----------------------------------------------

I agree: it will be better to rename the methods. And will be my pleasure to 
try to fix this :-) But I'm not sure about the depth of the change: should I 
change the names just in the DomainWithLimits class? Or should I go deeper and 
change also the methods/attributes in the wrapped class 
(SingleResourceWithLimitsDto)?

> Abiquo Hard Drive Size limits are in bytes, instead of Mb
> ---------------------------------------------------------
>
>                 Key: JCLOUDS-275
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-275
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-labs
>    Affects Versions: 1.7.0
>            Reporter: Carlos García Ibáñez
>              Labels: abiquo
>
> When setting the hard drive limits for an Enterprise or a Virtual Datacenter 
> we use the setLimitsInMb() method in the class DomainWithLimitsWrapper. The 
> values passed are then supposed to be in Mb, but we have noticed that the 
> Abiquo platform is interpreting them as bytes. The same applies to the 
> corresponding getters for the soft and hard limits.A conversion should be 
> made before sending the values to Abiquo (for the setters) or after 
> retrieving them (in the getters). Or maybe the methods should be renamed to 
> remove the reference to the units (Mb).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to