afs commented on issue #2518:
URL: https://github.com/apache/jena/issues/2518#issuecomment-2317520825

   @Olaf - in cleaning the ingested branch code, I found that `main.jj` does 
not build with javacc (I have version 7.0.12).
   
   There are [two uses of` 
Unfold`](https://github.com/apache/jena/pull/2501/files#diff-4d6097b4cd35d9151c6ba077f356ceb6b7aaa8f422b2787a2d464a9298581235R923-R934)
 
   and [two declarations of 
`Unfold`](https://github.com/apache/jena/pull/2501/files#diff-4d6097b4cd35d9151c6ba077f356ceb6b7aaa8f422b2787a2d464a9298581235R1066-R1102).
   
   This is not due to the ingestion/squash process onto the Jena branch - those 
links are to the PR #2501.
   
   I don't know how that could have happened but the generated java code did 
not correspond to the JavaCC input. The problem is now fixed.
   
   I've also added a Builder for `OpUnfold` so algebra using that operator can 
be written out and read in again. The command line tool `qparse` now works (it 
parses queries and also checks that they print out in a form that equals the 
input and also have the same algebra).
   
   I've finished cleaning up the code (warnings, some white space things I 
noticed) for now.
   
   Please test when you have some time.
   
   I'll keep the branch in-step with the main branch. There are some parser 
changes for RDF 1.2 in the pipeline.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to