hartig commented on issue #2518: URL: https://github.com/apache/jena/issues/2518#issuecomment-2322870373
@afs > in cleaning the ingested branch code, I found that main.jj does not build with javacc (I have version 7.0.12). > > There are [two uses of Unfold](https://github.com/apache/jena/pull/2501/files#diff-4d6097b4cd35d9151c6ba077f356ceb6b7aaa8f422b2787a2d464a9298581235R923-R934) > and [two declarations of Unfold](https://github.com/apache/jena/pull/2501/files#diff-4d6097b4cd35d9151c6ba077f356ceb6b7aaa8f422b2787a2d464a9298581235R1066-R1102). I didn't notice myself. I guess that this was an artifact of my earlier attempt to rebase my branch, which was a several-hours project after more than a year of divergence between the branches. > The problem is now fixed. Thanks! Thanks also for the other changes (Builder for `OpUnfold`, cleaning of warnings, etc). I looked through all your commits and they are fine. > Please test when you have some time. Done. Everything works as expected! That is, i) `mvn clean package` runs through without problems for that branch, ii) `arq.rdftests` runs our SPARQL CDTs test suite without issues, and iii) `arq.arq` can be used to run SPARQL queries that use our CDT-related features. So, from my side, this can be merged now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
