OyvindLGjesdal commented on issue #3738:
URL: https://github.com/apache/jena/issues/3738#issuecomment-3864003443

   Thank you, that works nicely for the download example. The shaded jar has 
the same issue that the serviceenhancer class files aren't included in the jar, 
when built from a fetched pom.
   
   I think the options here are changing the docs to include instead build from 
the git repo
   
   e.g:
   ```
   # from directory of jena
   mvn package -pl jena-serviceenhancer -am -Pbundle -DskipTests
   ```
    
   or include something like this in the SE pom to fetch the dependency (Claude 
suggested, works when placed in the bundle plugins section.)
   
   ```pom
   <!-- ... existing code ... -->
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-dependency-plugin</artifactId>
               <executions>
                 <execution>
                   <id>unpack-own-classes</id>
                   <phase>generate-resources</phase>
                   <goals>
                     <goal>unpack</goal>
                   </goals>
                   <configuration>
                     <artifactItems>
                       <artifactItem>
                         <groupId>org.apache.jena</groupId>
                         <artifactId>jena-serviceenhancer</artifactId>
                         <version>${project.version}</version>
                         <type>jar</type>
                         <overWrite>false</overWrite>
                         
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
                       </artifactItem>
                     </artifactItems>
                     <!-- Skip if classes already exist (normal build with 
sources) -->
                     <overWriteIfNewer>false</overWriteIfNewer>
                   </configuration>
                 </execution>
               </executions>
             </plugin>
   <!-- ... existing code ... -->
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to