Aklakan commented on issue #3738:
URL: https://github.com/apache/jena/issues/3738#issuecomment-3864103107

   > The shaded jar has the same issue that the serviceenhancer class files 
aren't included in the jar, when built from a fetched pom.
   
   This is expected, because creating the shaded jar from the downloaded pom 
will bundle the source code with the dependencies - and the source code is not 
there - so the set of source files is empty.
   
   The `unpack-own-classes` approach should indeed make it possible to build a 
shaded jar from a released maven project without requiring the source code to 
be present. It could be included as an additional profile.
   
   Another approach could be with OSGI. With OSGI, plugin dependencies could be 
isolated - so two plugins using e.g. different versions of guava would not 
conflict because OSGI would load them with different class loaders.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to