Am 4. Februar 2017 14:02:58 MEZ schrieb Vladimir Sitnikov 
<[email protected]>:
>It does not look good to me.
>I think
>1) SwingUtilities.invokeLater is missing

The timer lives in the awt thread, so we need no invokeLater. Or do I miss 
something?

>2) .clear() misses to set logChanged=true

The component is set to an empty text, so logChanged can be left alone, or even 
set to false. Don't you think?

>3) if (logChanged) should be expressed as if (!logChanged) {return;}

Probably.

>4) Do we really need a thread there? How that approach would scale
>across
>new components (e.g. statistics, etc, etc)?

You mean the timer thread?

Felix

>
>Vladimir

Reply via email to