On Sat, Feb 4, 2017 at 3:06 PM, Felix Schumacher < [email protected]> wrote:
> > > Am 4. Februar 2017 14:02:58 MEZ schrieb Vladimir Sitnikov < > [email protected]>: > >It does not look good to me. > >I think > >1) SwingUtilities.invokeLater is missing > > The timer lives in the awt thread, so we need no invokeLater. Or do I miss > something? > I agree. The only reason I would see for calling invokeLater would maybe to avoid freezing UI if the call takes more than some limit. > > >2) .clear() misses to set logChanged=true > > The component is set to an empty text, so logChanged can be left alone, or > even set to false. Don't you think? > > >3) if (logChanged) should be expressed as if (!logChanged) {return;} > > Probably. > > >4) Do we really need a thread there? How that approach would scale > >across > >new components (e.g. statistics, etc, etc)? > > You mean the timer thread? > I think so but I don't understand the comment. For me there is only 1 Timer thread no ? > > Felix > > > > >Vladimir > -- Cordialement. Philippe Mouawad.
