ASF GitHub Bot commented on KARAF-5300:

GitHub user cschneider opened a pull request:


    KARAF-5300 FeaturesService should use more specific classes for internal 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/karaf model_features

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #333
commit 728dcbeeaddf16d10c1d8a53599a364250239b7f
Author: Christian Schneider <ch...@die-schneider.net>
Date:   2017-08-09T13:51:45Z

    Extract common code in test

commit 54dac91a87e1f1f076bddc9556146d3bd42f0d5f
Author: Christian Schneider <ch...@die-schneider.net>
Date:   2017-08-09T15:39:06Z

    [KARAF-5300] Use FeatureReq instead of string for FeaturesService

commit be4a73b8e7c3815c7b4923e723ca1c53575085df
Author: Christian Schneider <ch...@die-schneider.net>
Date:   2017-08-10T08:33:22Z

    [KARAF-5300] Add documentation

commit e23d7bd69e84608612d9f0e594012b3a4ea4b8cf
Author: Christian Schneider <ch...@die-schneider.net>
Date:   2017-08-10T09:23:10Z

    [KARAF-5300] Split install into add and upgrade


> FeaturesService should use more specific classes for model
> ----------------------------------------------------------
>                 Key: KARAF-5300
>                 URL: https://issues.apache.org/jira/browse/KARAF-5300
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-feature
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
> Currently the feature service uses strings for many different purposes:
> - feature name
> - feature name glob
> - feature version
> - feature version range
> It is difficult to tell what purpose such a string has.
> I would like to create a type FeatureReq(name, VersionRange) that describes 
> better what we do. This should make the code a lot easier to understand.
> Ideally we would also reflect this in the service interface but the stay 
> backwards compatbile I will only use the new types internally.

This message was sent by Atlassian JIRA

Reply via email to