[
https://issues.apache.org/jira/browse/KARAF-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616786#comment-17616786
]
ASF GitHub Bot commented on KARAF-6319:
---------------------------------------
awrb commented on code in PR #1649:
URL: https://github.com/apache/karaf/pull/1649#discussion_r994179616
##########
manual/src/main/asciidoc/developer-guide/karaf-maven-plugin.adoc:
##########
@@ -471,6 +471,9 @@ The `karaf:assembly` goal creates a Karaf instance
(assembly) filesystem using t
<installedBundles>
<installedBundle>${additional.bundle}</installedBundle>
</installedBundles>
+ <prerequisiteFeatures>
+ <feature>ssh</feature>
Review Comment:
I used this name because it's already used in `GenerateDescriptorMojo`:
```
/**
* Name of features which are prerequisites (they still need to be
defined separately).
*/
@Parameter
private List<String> prerequisiteFeatures = new ArrayList<>();
```
also in provisioning.adoc:
```
===== Feature prerequisites
A prerequisite feature is a special kind of dependency. If you add the
`prerequisite` attribute to dependant feature tag then it will force
installation and also activation of bundles in the dependant feature before the
installation of the actual feature. This may be handy in the case that bundles
enlisted in a given feature are not using pre installed URLs such as `wrap` or
`war`.
----
<feature name="foo" version="1.0.0">
<feature prerequisite="true">bar</feature>
...
</feature>
----
```
so that was my thought process. I am happy to change it though,
`firstStageBootFeatures` is nice as it contains the stage name.
> Add <stageBootFeatures/> allowing to define the early stage boot features
> -------------------------------------------------------------------------
>
> Key: KARAF-6319
> URL: https://issues.apache.org/jira/browse/KARAF-6319
> Project: Karaf
> Issue Type: Improvement
> Components: karaf
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
>
> Right now, using the {{karaf:assembly}} goal, we can provide the
> {{<bootFeatures/>}}, ending in {{featuresBoot}} property in
> {{etc/org.apache.karaf.features.cfg}}.
> However, it's not possible during the assembly to specify the "early" stage
> boot features, for instance, something like:
> {code}
> featuresBoot=(instance,package,log,ssh,framework,feature),myfeature
> {code}
> I'm proposing to add (in the {{Builder}}) a {{<firstBootFeatures/>}} that
> will be adding in the early stage, before the "regular" {{<bootFeatures/>}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
