[
https://issues.apache.org/jira/browse/KARAF-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616800#comment-17616800
]
ASF GitHub Bot commented on KARAF-6319:
---------------------------------------
jbonofre commented on code in PR #1649:
URL: https://github.com/apache/karaf/pull/1649#discussion_r994207358
##########
manual/src/main/asciidoc/developer-guide/karaf-maven-plugin.adoc:
##########
@@ -471,6 +471,9 @@ The `karaf:assembly` goal creates a Karaf instance
(assembly) filesystem using t
<installedBundles>
<installedBundle>${additional.bundle}</installedBundle>
</installedBundles>
+ <prerequisiteFeatures>
+ <feature>ssh</feature>
Review Comment:
Yes, but the semantic is different: `prerequisite` is a flag in the feature
repository XML to define a feature should be fully installed before the current
feature. In the case of boot features, it's different because:
1. it's in `etc/org.apache.karaf.features.cfg` not in the features
repository XML (so global)
2. it's not really prerequisite but more staging (a feature in first stage
could have a prerequisite defined)
If you don't mind, I would prefer to use `firstStageBootFeatures`.
Thoughts ?
> Add <stageBootFeatures/> allowing to define the early stage boot features
> -------------------------------------------------------------------------
>
> Key: KARAF-6319
> URL: https://issues.apache.org/jira/browse/KARAF-6319
> Project: Karaf
> Issue Type: Improvement
> Components: karaf
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
>
> Right now, using the {{karaf:assembly}} goal, we can provide the
> {{<bootFeatures/>}}, ending in {{featuresBoot}} property in
> {{etc/org.apache.karaf.features.cfg}}.
> However, it's not possible during the assembly to specify the "early" stage
> boot features, for instance, something like:
> {code}
> featuresBoot=(instance,package,log,ssh,framework,feature),myfeature
> {code}
> I'm proposing to add (in the {{Builder}}) a {{<firstBootFeatures/>}} that
> will be adding in the early stage, before the "regular" {{<bootFeatures/>}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
