[
https://issues.apache.org/jira/browse/KUDU-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530333#comment-17530333
]
ASF subversion and git services commented on KUDU-3351:
-------------------------------------------------------
Commit 0ddcaaabc97c85a4715ae79ff5604feb9b342779 in kudu's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=0ddcaaabc ]
[client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and
DELETE_IGNORE. However, it was lacking the per-session metrics about how
many rows get ignored vs modified. This patch implements the per-session
metrics by introducing a new ResourceMetricsPB field into the
WriteResponsePB that's populated in every response sent back to the
client.
Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3
Reviewed-on: http://gerrit.cloudera.org:8080/18451
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
> Add insert error count metrics in WriteResponsePB
> -------------------------------------------------
>
> Key: KUDU-3351
> URL: https://issues.apache.org/jira/browse/KUDU-3351
> Project: Kudu
> Issue Type: Improvement
> Reporter: Riza Suminto
> Priority: Major
>
> KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and DELETE_IGNORE.
> However, it is currently lack of per-session metrics about how many rows get
> ignored vs modified.
> In regular INSERT operation, we depends on per_row_errors field in
> WriteResponsePB to count how many row operations are failed.
> [https://github.com/apache/kudu/blob/0cb2b7c/src/kudu/tserver/tserver.proto#L175-L183]
>
> But with INSERT_IGNORE, this field will be empty. We should add relevant
> metrics field to this WriteResponsePB.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
