[ 
https://issues.apache.org/jira/browse/KUDU-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775856#comment-17775856
 ] 

ASF subversion and git services commented on KUDU-3351:
-------------------------------------------------------

Commit c02ad2fe699c7607d6fbe52d2c7e73ca2313d36e in kudu's branch 
refs/heads/master from Marton Greber
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=c02ad2fe6 ]

[Python] KUDU-3351 Add write op metrics

This is a follow-up patch for commit:
0ddcaaabc97c85a4715ae79ff5604feb9b342779, adding per-session write op
metrics to the Python client.

In the test function "test_insert_and_mutate_rows" I added verification
function calls, to check that the metrics are gathered properly.
Only "upsert_ignore_errors" is left out, as UPSERT IGNORE is not yet
supported by the Python client. I'm planning to address that in the next
patch.

Change-Id: Id76f8f0cb11ef5e4b9d06508a39492bc6b0109a9
Reviewed-on: http://gerrit.cloudera.org:8080/20526
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>


> Add insert error count metrics in WriteResponsePB
> -------------------------------------------------
>
>                 Key: KUDU-3351
>                 URL: https://issues.apache.org/jira/browse/KUDU-3351
>             Project: Kudu
>          Issue Type: Improvement
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>             Fix For: 1.17.0
>
>
> KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and DELETE_IGNORE.
> However, it is currently lack of per-session metrics about how many rows get 
> ignored vs modified.
> In regular INSERT operation, we depends on per_row_errors field in 
> WriteResponsePB to count how many row operations are failed.
> [https://github.com/apache/kudu/blob/0cb2b7c/src/kudu/tserver/tserver.proto#L175-L183]
>  
> But with INSERT_IGNORE, this field will be empty. We should add relevant 
> metrics field to this WriteResponsePB.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to