[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #643: Optimize happy path for constructing Status

Tue, 21 Jun 2022 02:17:21 -0700 


PragmaTwice commented on code in PR #643:
URL: https://github.com/apache/incubator-kvrocks/pull/643#discussion_r902372341


##########
src/status.h:
##########
@@ -57,13 +57,18 @@ class Status {
     NetSendErr,
   };
 
-  Status() : Status(cOK, "ok") {}
-  explicit Status(Code code, std::string msg = "") : code_(code), 
msg_(std::move(msg)) {}
+  Status() : Status(cOK) {}
+  explicit Status(Code code, std::string msg = {}) : code_(code), 
msg_(std::move(msg)) {}
   bool IsOK() { return code_ == cOK; }
   bool IsNotFound() { return code_ == NotFound; }
   bool IsImorting() { return code_ == SlotImport; }

Review Comment:
   Maybe open a help wanted issue to encourage more involvementšŸ¤£ 
   Not sure whether it is a proper way, calling expert @tisonkun 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to