tisonkun commented on code in PR #643:
URL: https://github.com/apache/incubator-kvrocks/pull/643#discussion_r902383424
##########
src/status.h:
##########
@@ -57,13 +57,18 @@ class Status {
NetSendErr,
};
- Status() : Status(cOK, "ok") {}
- explicit Status(Code code, std::string msg = "") : code_(code),
msg_(std::move(msg)) {}
+ Status() : Status(cOK) {}
+ explicit Status(Code code, std::string msg = {}) : code_(code),
msg_(std::move(msg)) {}
bool IsOK() { return code_ == cOK; }
bool IsNotFound() { return code_ == NotFound; }
bool IsImorting() { return code_ == SlotImport; }
Review Comment:
There are several typos in our codebase. I don't think they deserve an issue
but if you'd like to fix it with another patch, go ahead. Otherwise I may
handle it later this week =。=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
