PragmaTwice commented on code in PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#discussion_r954493789
##########
src/encoding.cc:
##########
@@ -271,3 +271,77 @@ double DecodeDouble(const char *ptr) {
memcpy(&value, &decoded, sizeof(value));
return value;
}
+
+char* EncodeVarint32(char *dst, uint32_t v) {
Review Comment:
No logical mistake found. I just wonder if this loop unrolling will be more
efficient, e.g. protobuf seems do not unroll it.
https://sourcegraph.com/github.com/protocolbuffers/protobuf/-/blob/src/google/protobuf/io/coded_stream.h?L898:42&subtree=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
