PragmaTwice commented on code in PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#discussion_r954514839
##########
src/encoding.cc:
##########
@@ -271,3 +271,77 @@ double DecodeDouble(const char *ptr) {
memcpy(&value, &decoded, sizeof(value));
return value;
}
+
+char* EncodeVarint32(char *dst, uint32_t v) {
Review Comment:
I perform a benchmark here:
https://quick-bench.com/q/NlktQnulDGxmP1pcIIK6MLvjldk
It seems that this unrolling do not take much performance improvement.
Maybe my benchmark has some flaw, so you guys can review it and correct me :
)
cc @ShooterIT @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
