PragmaTwice commented on code in PR #1038: URL: https://github.com/apache/incubator-kvrocks/pull/1038#discussion_r1003309322
########## src/common/util.h: ########## @@ -68,6 +68,7 @@ std::vector<std::string> TokenizeRedisProtocol(const std::string &value); void ThreadSetName(const char *name); int aeWait(int fd, int mask, uint64_t milliseconds); +int64_t GetTimeStamp(); uint64_t GetTimeStampMS(); uint64_t GetTimeStampUS(); Review Comment: We can get second/millisecond/microsecond directly without division. ########## src/common/util.h: ########## @@ -68,6 +68,7 @@ std::vector<std::string> TokenizeRedisProtocol(const std::string &value); void ThreadSetName(const char *name); int aeWait(int fd, int mask, uint64_t milliseconds); +int64_t GetTimeStamp(); uint64_t GetTimeStampMS(); uint64_t GetTimeStampUS(); Review Comment: We can get second/millisecond/microsecond directly without manual division. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
