tisonkun commented on code in PR #1038:
URL:
https://github.com/apache/incubator-kvrocks/pull/1038#discussion_r1003327881
##########
src/common/util.cc:
##########
@@ -673,6 +673,8 @@ int aeWait(int fd, int mask, uint64_t timeout) {
}
}
+int64_t GetTimeStamp() { return static_cast<int64_t>(GetTimeStampMS() / 1000);
}
Review Comment:
Add a comment that the return value is in seconds? Also, why cannot we ass
this method as `GetTimeStampSeconds` in the `.h` file? And thus
`GetTimeStampMillis`/`GetTimeStampMicros`. At least I guess the common default
of timestamp is in milliseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
