git-hulk commented on PR #1047:
URL: 
https://github.com/apache/incubator-kvrocks/pull/1047#issuecomment-1293654416

   > 
https://github.com/apache/incubator-kvrocks/blob/debd8988d6f6978593ad35b7e06d0c3e773ee825/src/config/config.cc#L767-L771
   > 
   > Since **ALL `MultiStringField` cannot be rewritten**, so I think you need 
to change it to something like
   > 
   > ```
   > if (iter->second.IsMulti())
   > ```
   > 
   > in case of someone use `MultiStringField` but forget to include the config 
key in this check.
   
   Yes, that's right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to