git-hulk commented on code in PR #1047:
URL:
https://github.com/apache/incubator-kvrocks/pull/1047#discussion_r1007805771
##########
src/config/config.cc:
##########
@@ -273,23 +273,26 @@ void Config::initFieldValidator() {
}},
{"rename-command",
[](const std::string &k, const std::string &v) -> Status {
- std::vector<std::string> args = Util::Split(v, " \t");
- if (args.size() != 2) {
- return Status(Status::NotOK, "Invalid rename-command format");
- }
- auto commands = Redis::GetCommands();
- auto cmd_iter = commands->find(Util::ToLower(args[0]));
- if (cmd_iter == commands->end()) {
- return Status(Status::NotOK, "No such command in rename-command");
- }
- if (args[1] != "\"\"") {
- auto new_command_name = Util::ToLower(args[1]);
- if (commands->find(new_command_name) != commands->end()) {
- return Status(Status::NotOK, "Target command name already
exists");
+ std::vector<std::string> all_args = Util::Split(v, "\n");
Review Comment:
Okay, very sad that I made the field value as a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
