mapleFU commented on code in PR #1219:
URL:
https://github.com/apache/incubator-kvrocks/pull/1219#discussion_r1064556522
##########
src/server/server.cc:
##########
@@ -137,12 +137,17 @@ Status Server::Start() {
}
if (config_->cluster_enabled) {
+ auto s = cluster_->LoadClusterNodes(config_->NodesFilePath());
Review Comment:
@git-hulk unless you are writing whole block to the device, you cannot make
sure that multiple blocks are atomic sync to OS. Think about the cases below:
1. Write to OS: BLK1 ... BLKn
2. BLK1 - BLKn-1 is sync to disk. But BLKn not
3. System crashed
So, the most convenient way is using RocksDB to store it, or write a
checksum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
