mapleFU commented on code in PR #1219:
URL:
https://github.com/apache/incubator-kvrocks/pull/1219#discussion_r1064551701
##########
src/server/server.cc:
##########
@@ -137,12 +137,17 @@ Status Server::Start() {
}
if (config_->cluster_enabled) {
+ auto s = cluster_->LoadClusterNodes(config_->NodesFilePath());
Review Comment:
Okay, thanks for your patient explaination. But I still think we should
ignore it's error:
```
case LoadState::NodesInfo:
// std::getline swallowed the newline in the node info, so need to
add it back here
nodesInfo.append(line + "\n");
break;
```
I think write to os is not atomic, so, we may got a "teared" file if we
don't have any checksum. And, `Load` will failed if parsing failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
