PragmaTwice commented on code in PR #1418:
URL:
https://github.com/apache/incubator-kvrocks/pull/1418#discussion_r1185126759
##########
src/commands/cmd_cluster.cc:
##########
@@ -253,6 +278,10 @@ class CommandClusterX : public Commander {
int64_t slot_ = -1;
int slot_id_ = -1;
bool force_ = false;
+
+ bool sync_migrate_ = false;
+ int sync_migrate_timeout_ = 0;
+ std::shared_ptr<SyncMigrateContext> sync_migrate_ctx_ = nullptr;
Review Comment:
Could you share some reason to use `std::shared_ptr`? Seems except here (not
necessary in my opinion) I cannot find where the object is "shared".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
