xiaobiaozhao commented on PR #1418:
URL:
https://github.com/apache/incubator-kvrocks/pull/1418#issuecomment-1536341427
> @ellutionist Thanks for your explanation.
>
> I have not dived into these changes deeply, but if you just want to make
lifetime of SyncMigrateContext as long as the command object, you can store an
instance of SyncMigrateContext in CommandClusterX directly (`class
CommandClusterX { SyncMigrateContext ctx_; ... }`), and pass some non-owning
pointer (like raw pointer, no ownership) to the migrator.
I agree with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
