git-hulk commented on PR #1418:
URL:
https://github.com/apache/incubator-kvrocks/pull/1418#issuecomment-1542401986
The implementation generally looks good to me, left a few comments:
- The blockingLock function looks unnecessary, it's fine to use
`std::unique_lock<std::mutex>lock(blocking_mutex_);` directly
- For the naming issue, SyncMigrateContext::(StartBlock|Wakeup) is a bit
inconsistent with Migrator::(StartBlocking|WakeupBlocking|CancelBlocking).
- Those functions in SyncMigrateContext can be private:
void OnWrite(bufferevent *bev); => void onWrite(bufferevent *bev);
void OnEvent(bufferevent *bev, int16_t events); => void
onEvent(bufferevent *bev, int16_t events);
void TimerCB(int, int16_t events); => void timerCB(int, int16_t events);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
