torwig commented on code in PR #1444:
URL: 
https://github.com/apache/incubator-kvrocks/pull/1444#discussion_r1199765125


##########
src/commands/cmd_set.cc:
##########
@@ -283,6 +285,55 @@ class CommandSInter : public Commander {
   }
 };
 
+/*
+ * description:
+ *
+ *    syntax: SINTERCARD numkeys key [key ...] [LIMIT limit]
+ *
+ *    params: the checked cardinality is unlimited (limit <= 0).

Review Comment:
   Redis prohibits the negative `LIMIT` parameter:
   
   ```
   127.0.0.1:6379> sintercard 2 set1 set2 limit -5
   (error) ERR LIMIT can't be negative
   127.0.0.1:6379> 
   ```
   
   BTW: right now the phrase `the checked cardinality is unlimited` sounds 
weird to me. 
   Since `Kvrocks` supports `Redis` protocol, if you want to add some 
documentation, you can just copy-paste sentences directly from `Redis` docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to