infdahai commented on code in PR #1444:
URL:
https://github.com/apache/incubator-kvrocks/pull/1444#discussion_r1201862674
##########
src/commands/cmd_set.cc:
##########
@@ -371,6 +418,7 @@ REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandSAdd>("sadd",
-3, "write", 1, 1, 1),
MakeCmdAttr<CommandSDiff>("sdiff", -2, "read-only", 1,
-1, 1),
MakeCmdAttr<CommandSUnion>("sunion", -2, "read-only",
1, -1, 1),
MakeCmdAttr<CommandSInter>("sinter", -2, "read-only",
1, -1, 1),
+ MakeCmdAttr<CommandSInterCard>("sintercard", -3,
"read-only", 1, -1, 1),
Review Comment:
@PragmaTwice Would it be better to use this change based on the syntax
`SINTERCARD numkeys key [key ...] [LIMIT limit]` ? It seems this range is
related to `watch`
```suggestion
MakeCmdAttr<CommandSInterCard>("sintercard", -3,
"read-only", 2, -1, 1),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
