torwig commented on code in PR #1464:
URL:
https://github.com/apache/incubator-kvrocks/pull/1464#discussion_r1202336424
##########
tests/gocase/integration/slotmigrate/slotmigrate_test.go:
##########
@@ -413,22 +413,18 @@ func TestSlotMigrateSync(t *testing.T) {
t.Run("MIGRATE - Migrate sync with (or without) all kinds of timeouts",
func(t *testing.T) {
slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync").Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", -1).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 0).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 10).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 0.5).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", -3.14).Val())
+ // migrate sync without explicitly specify the timeout
+ result := rdb0.Do(ctx, "clusterx", "migrate", slot, id1, "sync")
+ require.NoError(t, result.Err())
+ require.Equal(t, "OK", result.Val())
+
+ timeouts := []interface{}{-1, 0, 20, 10.5, -3.14}
Review Comment:
@ellutionist Timeout is in seconds as far as I see so I don't think that
making the timeout less than 1 second is reasonable (it's about migrating slot
with data from one node to another via network).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
