torwig commented on code in PR #1464:
URL:
https://github.com/apache/incubator-kvrocks/pull/1464#discussion_r1202515406
##########
tests/gocase/integration/slotmigrate/slotmigrate_test.go:
##########
@@ -435,17 +435,15 @@ func TestSlotMigrateSync(t *testing.T) {
})
t.Run("MIGRATE - Migrate sync timeout", func(t *testing.T) {
- cnt := 200000
slot++
+ cnt := 200000
for i := 0; i < cnt; i++ {
require.NoError(t, rdb0.LPush(ctx,
util.SlotTable[slot], i).Err())
}
- timeout := 0.001
-
- require.Nil(t, rdb0.Do(ctx, "clusterx", "migrate", slot, id1,
"sync", timeout).Val())
- // check the following command on the same connection
- require.Equal(t, "PONG", rdb0.Ping(ctx).Val())
Review Comment:
@git-hulk Yes, absolutely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]