torwig commented on code in PR #1444:
URL:
https://github.com/apache/incubator-kvrocks/pull/1444#discussion_r1216727167
##########
tests/cppunit/types/set_test.cc:
##########
@@ -188,9 +188,41 @@ TEST_F(RedisSetTest, Inter) {
std::vector<std::string> members;
set_->Inter({k1, k2, k3}, &members);
EXPECT_EQ(1, members.size());
+ set_->Inter({k1, k2, k4}, &members);
+ EXPECT_EQ(0, members.size());
+ set_->Del(k1);
+ set_->Del(k2);
+ set_->Del(k3);
+ set_->Del(k4);
+}
+
+TEST_F(RedisSetTest, InterCard) {
+ uint64_t ret = 0;
+ std::string k1 = "key1", k2 = "key2", k3 = "key3", k4 = "key4";
+ rocksdb::Status s = set_->Add(k1, {"a", "b", "c", "d"}, &ret);
+ EXPECT_EQ(ret, 4);
+ set_->Add(k2, {"c", "d", "e"}, &ret);
+ EXPECT_EQ(ret, 3);
+ set_->Add(k3, {"e", "f"}, &ret);
+ EXPECT_EQ(ret, 2);
+ set_->InterCard({k1, k2}, 0, &ret);
+ EXPECT_EQ(ret, 2);
+ set_->InterCard({k1, k2}, 1, &ret);
+ EXPECT_EQ(ret, 1);
+ set_->InterCard({k1, k2}, 3, &ret);
+ EXPECT_EQ(ret, 2);
+ set_->InterCard({k2, k3}, 1, &ret);
+ EXPECT_EQ(ret, 1);
+ set_->InterCard({k1, k3}, 5, &ret);
+ EXPECT_EQ(ret, 0);
+ set_->InterCard({k1, k4}, 5, &ret);
+ EXPECT_EQ(ret, 0);
+ set_->InterCard({k1}, 0, &ret);
+ EXPECT_EQ(ret, 4);
Review Comment:
If I add the following test:
```
set_->InterCard({k1}, 2, &ret);
EXPECT_EQ(ret, 2);
```
it will fail.
I tested it here: https://redis.io/commands/sintercard/
```
redis> sintercard 1 key1 limit 0
(integer) 4
redis> sintercard 1 key1 limit 2
(integer) 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
