torwig commented on code in PR #1444:
URL:
https://github.com/apache/incubator-kvrocks/pull/1444#discussion_r1227096570
##########
src/types/redis_set.cc:
##########
@@ -358,6 +358,54 @@ rocksdb::Status Set::Inter(const std::vector<Slice> &keys,
std::vector<std::stri
return rocksdb::Status::OK();
}
+rocksdb::Status Set::InterCard(const std::vector<Slice> &keys, uint64_t limit,
uint64_t *cnt) {
+ *cnt = 0;
+
+ std::map<std::string, size_t> member_counters;
+ std::vector<std::string> target_members;
+
+ auto s = Members(keys[0], &target_members);
+ if (!s.ok() || target_members.empty()) return s;
+ for (const auto &member : target_members) {
+ member_counters[member] = 1;
+ }
+ if (limit == 0) {
+ limit = target_members.size();
+ }
+
+ size_t keys_size = keys.size();
+ if (keys_size == 1) {
+ *cnt = std::min(static_cast<uint64_t>(target_members.size()), limit);
+ return rocksdb::Status::OK();
+ }
+
+ int cardinality = 0;
+ bool limit_reached = false;
+ for (size_t i = 1; i < keys_size; i++) {
+ s = Members(keys[i], &target_members);
+ if (!s.ok() || target_members.empty()) {
+ return s;
+ }
+
+ for (const auto &member : target_members) {
+ auto iter = member_counters.find(member);
+ if (iter == member_counters.end()) continue;
+ if (++iter->second == keys_size) {
+ cardinality++;
Review Comment:
Is there any reason to introduce a new variable `cardinality` and later
increment it instead of incrementing the `cnt` variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
