git-hulk commented on PR #1493: URL: https://github.com/apache/incubator-kvrocks/pull/1493#issuecomment-1587462592
> @git-hulk Yes, `Server::Stop` will cancel and `Server::Join` will join all threads. Additionally, here https://github.com/apache/incubator-kvrocks/blob/unstable/src/common/task_runner.cc#L48 should we stop joining threads when the first call to `util::ThreadJoin` or just log an error and continue joining other threads? oooh, my bad. I didn't see that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
