git-hulk commented on PR #1493:
URL:
https://github.com/apache/incubator-kvrocks/pull/1493#issuecomment-1588433616
> @git-hulk My idea was to change the loop to the following:
>
> ```
> for (auto &thread : threads_) {
> if (auto s = util::ThreadJoin(thread); !s) {
> LOG(WARNING) << "Failed to join thread: " << s.Msg();
> continue;
> }
> }
> ```
>
> What do you think about that? @PragmaTwice What is your opinion on that?
Yes, it's good to only log an error when failing to join since other places
like the worker thread only prints an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
