git-hulk commented on code in PR #1493:
URL:
https://github.com/apache/incubator-kvrocks/pull/1493#discussion_r1226769983
##########
src/server/server.cc:
##########
@@ -230,15 +230,15 @@ void Server::Join() {
worker->Join();
}
- if (auto s = task_runner_.Join(); !s) {
- LOG(WARNING) << s.Msg();
- }
if (auto s = util::ThreadJoin(cron_thread_); !s) {
LOG(WARNING) << "Cron thread operation failed: " << s.Msg();
}
if (auto s = util::ThreadJoin(compaction_checker_thread_); !s) {
LOG(WARNING) << "Compaction checker thread operation failed: " << s.Msg();
}
+ if (auto s = task_runner_.Join(); !s) {
+ LOG(WARNING) << "Task runner thread operation failed: " << s.Msg();
Review Comment:
```suggestion
LOG(WARNING) << s.Msg();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
