infdahai commented on code in PR #1498:
URL:
https://github.com/apache/incubator-kvrocks/pull/1498#discussion_r1232481337
##########
src/config/config.cc:
##########
@@ -659,6 +659,12 @@ Status Config::parseConfigFromPair(const
std::pair<std::string, std::string> &in
tokens[input.second] = input.first.substr(ns_str_size);
}
auto iter = fields_.find(field_key);
+
+ // Check if a configuration key is a valid key
Review Comment:
Can you explain why does it works here?
We write configs to `fields_`.
https://github.com/apache/incubator-kvrocks/blob/46e7eaf428c3e4935cc73f70be3f8c9066d5cb3c/src/config/config.cc#L226-L230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
