gloof11 commented on code in PR #1498:
URL:
https://github.com/apache/incubator-kvrocks/pull/1498#discussion_r1232920769
##########
src/config/config.cc:
##########
@@ -659,6 +659,12 @@ Status Config::parseConfigFromPair(const
std::pair<std::string, std::string> &in
tokens[input.second] = input.first.substr(ns_str_size);
}
auto iter = fields_.find(field_key);
+
+ // Check if a configuration key is a valid key
Review Comment:
I was wondering what the properties of "fields" was. This was a very hacky
fix, so I will dig deeper to see if I can make the code more "understandable"
and less "magic" lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
