torwig commented on code in PR #1498:
URL:
https://github.com/apache/incubator-kvrocks/pull/1498#discussion_r1233060766
##########
src/config/config.cc:
##########
@@ -658,7 +658,13 @@ Status Config::parseConfigFromPair(const
std::pair<std::string, std::string> &in
field_key = input.first;
tokens[input.second] = input.first.substr(ns_str_size);
}
+
auto iter = fields_.find(field_key);
+
+ if (iter == fields_.end()) {
Review Comment:
Would you like to move the warning message inside `else` branch of `if (iter
!= fields_.end()) {` check which is located later?
P.S. I think you can omit a lot of `!` inside the message, just capitalize
the word 'warning' as `WARNING:...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
