PragmaTwice commented on code in PR #1489:
URL:
https://github.com/apache/incubator-kvrocks/pull/1489#discussion_r1234119564
##########
tests/gocase/unit/scan/scan_test.go:
##########
@@ -52,13 +52,27 @@ func TestScanEmptyKey(t *testing.T) {
require.Equal(t, []string{"", "fab", "fiz", "foobar"}, keys)
}
-func TestScan(t *testing.T) {
+func TestScanWithNumberCursor(t *testing.T) {
srv := util.StartServer(t, map[string]string{})
defer srv.Close()
+ ctx := context.Background()
+ rdb := srv.NewClient()
+ defer func() { require.NoError(t, rdb.Close()) }()
+ require.NoError(t, rdb.ConfigSet(ctx, "redis-cursor-compatible",
"yes").Err())
Review Comment:
I think `redis-cursor-compatible` set to `yes` is a default behavior. Could
you add test for `redis-cursor-compatible` set to `no`? (e.g. ScanTest works
well and `--bigkeys` fails.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
