git-hulk commented on code in PR #1489:
URL: 
https://github.com/apache/incubator-kvrocks/pull/1489#discussion_r1234138882


##########
src/config/config.cc:
##########
@@ -165,6 +165,7 @@ Config::Config() {
       {"unixsocketperm", true, new OctalField(&unixsocketperm, 0777, 1, 
INT_MAX)},
       {"log-retention-days", false, new IntField(&log_retention_days, -1, -1, 
INT_MAX)},
       {"persist-cluster-nodes-enabled", false, new 
YesNoField(&persist_cluster_nodes_enabled, true)},
+      {"redis-cursor-compatible", false, new 
YesNoField(&redis_cursor_compatible, true)},

Review Comment:
   Yes, it will break the old users if they upgraded the Kvrocks without adding 
the new configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to