aleksraiden commented on code in PR #1516:
URL: https://github.com/apache/kvrocks/pull/1516#discussion_r1241085046
##########
x.py:
##########
@@ -106,7 +106,7 @@ def build(dir: str, jobs: Optional[int], ghproxy: bool,
ninja: bool, unittest: b
makedirs(dir, exist_ok=True)
- cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo"]
+ cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo", "-DPORTABLE=0"]
Review Comment:
> It should be broken by this PR:
[facebook/rocksdb#11419](https://github.com/facebook/rocksdb/pull/11419). But I
think we can remove `"-DPORTABLE=0"` since the default value has been corrected
to 0 in the previous line:
https://github.com/apache/kvrocks/pull/1516/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR32
No, default value, if we set 0 or 1, cmake rewrite into own default ON/OFF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
