aleksraiden commented on code in PR #1516:
URL: https://github.com/apache/kvrocks/pull/1516#discussion_r1241106179
##########
x.py:
##########
@@ -106,7 +106,7 @@ def build(dir: str, jobs: Optional[int], ghproxy: bool,
ninja: bool, unittest: b
makedirs(dir, exist_ok=True)
- cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo"]
+ cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo", "-DPORTABLE=0"]
Review Comment:
Yes, but we need manual setup always, because in rocksdb.cmake we use it.
So, only one right way in now - always manual set PORTABLE as a Cmake flag
on build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
